Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URLs and field names to match the new vega weather datasets #2310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joelostblom
Copy link
Contributor

This fixes the broken weather sections in the docs mentioned in #2213. I upated based on my understanding of altair-viz/vega_datasets#40.

@joelostblom joelostblom changed the title Update URLs and field names to match new vega datasets Update URLs and field names to match rhe new vega weather datasets Oct 7, 2020
@joelostblom joelostblom changed the title Update URLs and field names to match rhe new vega weather datasets Update URLs and field names to match the new vega weather datasets Oct 7, 2020
@joelostblom
Copy link
Contributor Author

All test failures are related to me using the new name for the seattle data set from altair-viz/vega_datasets#40, and should be fixed once that is merged.

@jakevdp
Copy link
Collaborator

jakevdp commented Oct 7, 2020

Thanks for this.

What needs to happen to fix this issue:

  • a new minor release of vega-datasets 1.X that pins the old URLs, so that it can work with older Altair versions
  • a new micro release of Altair with accompanying doc build with the older vega-datasets path
  • a new minor release of Altair that makes all the required updates to work with vega-datasets 2.X

I've not done that yet, because it's a ~half day of work to get right, and I've not had an open half day in half a year.

@jakevdp
Copy link
Collaborator

jakevdp commented Oct 7, 2020

I should say: thanks for the contribution. I really appreciate it. But we can't merge changes like this until 1 & 2 are done.

@joelostblom
Copy link
Contributor Author

Thank you for responding so quickly! I understand that you are super busy and I didn't want to stress, more just checking in if I could do something helpful for moving this forward. But it sounds like most things you mentioned are release related, which sounds a bit tricky to help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants